1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401 | /*************************************************************************
*
* Project
* _____ _____ __ __ _____
* / ____| __ \| \/ | __ \
* ___ _ __ ___ _ __ | | __| |__) | \ / | |__) |
* / _ \| '_ \ / _ \ '_ \| | |_ | ___/| |\/| | ___/
*| (_) | |_) | __/ | | | |__| | | | | | | |
* \___/| .__/ \___|_| |_|\_____|_| |_| |_|_|
* | |
* |_|
*
* Copyright (C) Akiel Aries, <akiel@akiel.org>, et al.
*
* This software is licensed as described in the file LICENSE, which
* you should have received as part of this distribution. The terms
* among other details are referenced in the official documentation
* seen here : https://akielaries.github.io/openGPMP/ along with
* important files seen in this project.
*
* You may opt to use, copy, modify, merge, publish, distribute
* and/or sell copies of the Software, and permit persons to whom
* the Software is furnished to do so, under the terms of the
* LICENSE file. As this is an Open Source effort, all implementations
* must be of the same methodology.
*
*
*
* This software is distributed on an AS IS basis, WITHOUT
* WARRANTY OF ANY KIND, either express or implied.
*
************************************************************************/
/** Integer type GEneral Matrix-Matrix product */
#include <cmath>
#include <limits>
#include <openGPMP/linalg/_igemm.hpp>
#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
// MATRIX BUFFERS
int gpmp::linalg::IGEMM::IGEMM_BUFF_A[BLOCK_SZ_M * BLOCK_SZ_K];
int gpmp::linalg::IGEMM::IGEMM_BUFF_B[BLOCK_SZ_K * BLOCK_SZ_N];
int gpmp::linalg::IGEMM::IGEMM_BUFF_C[BLOCK_SZ_MR * BLOCK_SZ_NR];
// pack micro panels of size BLOCK_SZ_MR rows by k columns from A without
// padding
void gpmp::linalg::IGEMM::pack_micro_A(int k,
const int *A,
int incRowA,
int incColA,
int *buffer) {
int i, j;
for (j = 0; j < k; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
buffer[i] = A[i * incRowA];
}
buffer += BLOCK_SZ_MR;
A += incColA;
}
}
// packs panels from A with padding if needed
void gpmp::linalg::IGEMM::pack_buffer_A(int mc,
int kc,
const int *A,
int incRowA,
int incColA,
int *buffer) {
int mp = mc / BLOCK_SZ_MR;
int _mr = mc % BLOCK_SZ_MR;
int i, j;<--- The scope of the variable 'j' can be reduced. [+]The scope of the variable 'j' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
for (i = 0; i < mp; ++i) {
pack_micro_A(kc, A, incRowA, incColA, buffer);
buffer += kc * BLOCK_SZ_MR;
A += BLOCK_SZ_MR * incRowA;
}
if (_mr > 0) {
for (j = 0; j < kc; ++j) {
for (i = 0; i < _mr; ++i) {
buffer[i] = A[i * incRowA];
}
for (i = _mr; i < BLOCK_SZ_MR; ++i) {
buffer[i] = 0;
}
buffer += BLOCK_SZ_MR;
A += incColA;
}
}
}
// packing complete panels from B of size BLOCK_SZ_NR by k columns
void gpmp::linalg::IGEMM::pack_micro_B(int k,
const int *B,
int incRowB,
int incColB,
int *buffer) {
int i, j;
for (i = 0; i < k; ++i) {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
buffer[j] = B[j * incColB];
}
buffer += BLOCK_SZ_NR;
B += incRowB;
}
}
// packing panels from B with padding if needed
void gpmp::linalg::IGEMM::pack_buffer_B(int kc,
int nc,
const int *B,
int incRowB,
int incColB,
int *buffer) {
int np = nc / BLOCK_SZ_NR;
int _nr = nc % BLOCK_SZ_NR;
int i, j;<--- The scope of the variable 'i' can be reduced. [+]The scope of the variable 'i' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
for (j = 0; j < np; ++j) {
pack_micro_B(kc, B, incRowB, incColB, buffer);
buffer += kc * BLOCK_SZ_NR;
B += BLOCK_SZ_NR * incColB;
}
if (_nr > 0) {
for (i = 0; i < kc; ++i) {
for (j = 0; j < _nr; ++j) {
buffer[j] = B[j * incColB];
}
for (j = _nr; j < BLOCK_SZ_NR; ++j) {
buffer[j] = 0;
}
buffer += BLOCK_SZ_NR;
B += incRowB;
}
}
}
// micro kernel that multiplies panels from A and B
void gpmp::linalg::IGEMM::igemm_micro_kernel(int kc,
int alpha,
const int *A,
const int *B,
int beta,
int *C,
int incRowC,
int incColC) {
int AB[BLOCK_SZ_MR * BLOCK_SZ_NR];
int i, j, l;
// Compute AB = A*B
for (l = 0; l < BLOCK_SZ_MR * BLOCK_SZ_NR; ++l) {
AB[l] = 0;
}
for (l = 0; l < kc; ++l) {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
AB[i + j * BLOCK_SZ_MR] += A[i] * B[j];
}
}
A += BLOCK_SZ_MR;
B += BLOCK_SZ_NR;
}
// Update C <- beta*C
if (beta == 0) {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
C[i * incRowC + j * incColC] = 0;
}
}
} else if (beta != 1) {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
C[i * incRowC + j * incColC] *= beta;
}
}
}
// Update C <- C + alpha*AB (note: the case alpha==0 was already treated
// in
// the above layer igemm_nn)
if (alpha == 1) {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
C[i * incRowC + j * incColC] += AB[i + j * BLOCK_SZ_MR];
}
}
}
else {
for (j = 0; j < BLOCK_SZ_NR; ++j) {
for (i = 0; i < BLOCK_SZ_MR; ++i) {
C[i * incRowC + j * incColC] += alpha * AB[i + j * BLOCK_SZ_MR];
}
}
}
}
// Compute Y += alpha*X (int precision AX + Y)
void gpmp::linalg::IGEMM::igeaxpy(int m,
int n,
int alpha,
const int *X,
int incRowX,
int incColX,
int *Y,
int incRowY,
int incColY) {
int i, j;
if (alpha != 1) {
for (j = 0; j < n; ++j) {
for (i = 0; i < m; ++i) {
Y[i * incRowY + j * incColY] +=
alpha * X[i * incRowX + j * incColX];
}
}
}
else {
for (j = 0; j < n; ++j) {
for (i = 0; i < m; ++i) {
Y[i * incRowY + j * incColY] += X[i * incRowX + j * incColX];
}
}
}
}
// Compute X *= alpha (scale elements)
void gpmp::linalg::IGEMM::igescal(int m,
int n,
int alpha,
int *X,
int incRowX,
int incColX) {
int i, j;
if (alpha != 0) {
for (j = 0; j < n; ++j) {
for (i = 0; i < m; ++i) {
X[i * incRowX + j * incColX] *= alpha;
}
}
}
else {
for (j = 0; j < n; ++j) {
for (i = 0; i < m; ++i) {
X[i * incRowX + j * incColX] = 0;
}
}
}
}
// Macro Kernel for the multiplication of blocks of A and B. We assume that
// these blocks were previously packed to buffers IGEMM_BUFF_A and IGEMM_BUFF_B.
void gpmp::linalg::IGEMM::igemm_macro_kernel(int mc,
int nc,
int kc,
int alpha,
int beta,
int *C,
int incRowC,
int incColC) {
int mp = (mc + BLOCK_SZ_MR - 1) / BLOCK_SZ_MR;
int np = (nc + BLOCK_SZ_NR - 1) / BLOCK_SZ_NR;
int _mr = mc % BLOCK_SZ_MR;
int _nr = nc % BLOCK_SZ_NR;
int mr, nr;<--- The scope of the variable 'nr' can be reduced. [+]The scope of the variable 'nr' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
int i, j;
for (j = 0; j < np; ++j) {
nr = (j != np - 1 || _nr == 0) ? BLOCK_SZ_NR : _nr;
for (i = 0; i < mp; ++i) {
mr = (i != mp - 1 || _mr == 0) ? BLOCK_SZ_MR : _mr;
if (mr == BLOCK_SZ_MR && nr == BLOCK_SZ_NR) {
igemm_micro_kernel(
kc,
alpha,
&IGEMM_BUFF_A[i * kc * BLOCK_SZ_MR],
&IGEMM_BUFF_B[j * kc * BLOCK_SZ_NR],
beta,
&C[i * BLOCK_SZ_MR * incRowC + j * BLOCK_SZ_NR * incColC],
incRowC,
incColC);
} else {
igemm_micro_kernel(kc,
alpha,
&IGEMM_BUFF_A[i * kc * BLOCK_SZ_MR],
&IGEMM_BUFF_B[j * kc * BLOCK_SZ_NR],
0,
IGEMM_BUFF_C,
1,
BLOCK_SZ_MR);
igescal(
mr,
nr,
beta,
&C[i * BLOCK_SZ_MR * incRowC + j * BLOCK_SZ_NR * incColC],
incRowC,
incColC);
igeaxpy(
mr,
nr,
1.0,
IGEMM_BUFF_C,
1,
BLOCK_SZ_MR,
&C[i * BLOCK_SZ_MR * incRowC + j * BLOCK_SZ_NR * incColC],
incRowC,
incColC);
}
}
}
}
// Main IGEMM entrypoint, compute C <- beta*C + alpha*A*B
void gpmp::linalg::IGEMM::igemm_nn(int m,
int n,
int k,
int alpha,
const int *A,
int incRowA,
int incColA,
const int *B,
int incRowB,
int incColB,
int beta,
int *C,
int incRowC,
int incColC) {
int mb = (m + BLOCK_SZ_M - 1) / BLOCK_SZ_M;
int nb = (n + BLOCK_SZ_N - 1) / BLOCK_SZ_N;
int kb = (k + BLOCK_SZ_K - 1) / BLOCK_SZ_K;
int _mc = m % BLOCK_SZ_M;
int _nc = n % BLOCK_SZ_N;
int _kc = k % BLOCK_SZ_K;
int mc, nc, kc;<--- The scope of the variable 'nc' can be reduced. [+]The scope of the variable 'nc' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced:
void f(int x)
{
int i = 0;
if (x) {
// it's safe to move 'int i = 0;' here
for (int n = 0; n < 10; ++n) {
// it is possible but not safe to move 'int i = 0;' here
do_something(&i);
}
}
}
When you see this message it is always safe to reduce the variable scope 1 level.
int i, j, l;
int _beta;
if (alpha == 0 || k == 0) {
igescal(m, n, beta, C, incRowC, incColC);
return;
}
for (j = 0; j < nb; ++j) {
nc = (j != nb - 1 || _nc == 0) ? BLOCK_SZ_N : _nc;
for (l = 0; l < kb; ++l) {
kc = (l != kb - 1 || _kc == 0) ? BLOCK_SZ_K : _kc;
_beta = (l == 0) ? beta : 1.0;
pack_buffer_B(
kc,
nc,
&B[l * BLOCK_SZ_K * incRowB + j * BLOCK_SZ_N * incColB],
incRowB,
incColB,
IGEMM_BUFF_B);
for (i = 0; i < mb; ++i) {
mc = (i != mb - 1 || _mc == 0) ? BLOCK_SZ_M : _mc;
pack_buffer_A(
mc,
kc,
&A[i * BLOCK_SZ_M * incRowA + l * BLOCK_SZ_K * incColA],
incRowA,
incColA,
IGEMM_BUFF_A);
igemm_macro_kernel(
mc,
nc,
kc,
alpha,
_beta,
&C[i * BLOCK_SZ_M * incRowC + j * BLOCK_SZ_N * incColC],
incRowC,
incColC);
}
}
}
}
|